Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Tagging subscribers to this area: @dotnet/area-system-text-encoding
See info in area-owners.md if you want to be subscribed.

@EgorBo, fyi

@EgorBo, fyi

I've almost finished it but I'll wait for this PR to land and ideally a daily SDK to pick it up for easier testing/benchmarking if you don't mind 🙂

PS: if we could put this API into Utf8 class it would be easier for JIT but should work as is too. There is a small problem in JIT that it never inlines methods Encoding.UTF8.X without PGO (#85209)

There is a small problem in JIT that it never inlines methods Encoding.UTF8.X without PGO (#85209)

😦

"small problem"... so... fixable?

There is a small problem in JIT that it never inlines methods Encoding.UTF8.X without PGO (#85209)

😦

"small problem"... so... fixable?

We discussed some solutions, in the worst case we'll just intrinsify Encoding.UTF8 to return exact type right in the importer. But a proper fix will be better since many other use cases will benefit from it. My initial impl needs PGO being enabled but I'll land a workaround after it